Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "linux: Init 5.8"" #95162

Closed
wants to merge 1 commit into from
Closed

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 11, 2020

This reverts commit fee8c0a.

With the necessary systemd bump in place, we can undo the revert.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This reverts commit fee8c0a.

With the necessary systemd bump in place, we can undo the revert.
@flokli
Copy link
Contributor Author

flokli commented Aug 11, 2020

This currently can't be tested due to #95163.

@flokli
Copy link
Contributor Author

flokli commented Aug 12, 2020

Rebased on latest master (now containing the fix for #95163).

It seems the bump to systemd 245.7 containing the necessary fixes for linux 5.8 wasn't part of the previous staging next round, so we'd need to wait for the next round (which hasn't opened yet) to have landed in master.

Then, this can be rebased to latest master, and we can run nixosTests.latestKernel.login.

@colemickens
Copy link
Member

What's the latest on this?

@hpfr
Copy link

hpfr commented Aug 19, 2020

@colemickens It's dependent on systemd 245.7 which as flokli said missed the last round of staging. See https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+staging+next to check the status of staging. As you can see in the commits in #95492, the latest round of staging, systemd 245.7 is pending merge. Once that PR is merged, this PR can be merged, and then it will get to nixos-unstable after the tests pass. So it could be a while...

@flokli also, it appears @vcunat recently committed the contents of this PR to the staging next PR. So can this be closed?

@vcunat
Copy link
Member

vcunat commented Aug 19, 2020

Oh, it didn't occur to me there could be a PR for this.

@vcunat vcunat closed this Aug 19, 2020
@flokli flokli deleted the linux-5.8 branch August 19, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants