nix-doc: init at 0.3.3 #95161
Merged
nix-doc: init at 0.3.3 #95161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies about the sneaky edits, there was a pretty nasty bug I found and squished while doing final validation on the package. |
lf-
force-pushed
the
patch-1
branch
3 times, most recently
from
2aec9e1
to
9fbf770
Compare
|
OK I am done smuggling in changes. It builds and runs now with no issues, and contains two fewer bugs than when I started :) |
|
@lf- you will be asked to create a separate commit to add yourself as a maintainer as |
|
You can also ignore that |
lf-
force-pushed
the
patch-1
branch
2 times, most recently
from
50502e9
to
0220ace
Compare
|
Thanks for the review @IvarWithoutBones. The requested changes have been made. |
|
@IvarWithoutBones changed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It was requested by @gvolpe :)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)re: the ??? above, nixpkgs-review did not find anything when I ran it post-commit, and
nix path-info -Shit the intentionally failing pseudo-package, so I'm not sure how I'm supposed to do that piece.