Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: 26.3 -> 27.1 #95169

Merged
merged 1 commit into from Aug 11, 2020
Merged

emacs: 26.3 -> 27.1 #95169

merged 1 commit into from Aug 11, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Aug 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DamienCassou
Copy link
Contributor

Result of nixpkgs-review pr 95169 1

18 packages failed to build:
- aerc
- afew
- agdaPackages.iowa-stdlib
- alot (python38Packages.alot)
- astroid
- cedille
- haskellPackages.notmuch
- idutils
- lieer
- meli
- muchsync
- neomutt
- notmuch
- notmuch-addrlookup
- python27Packages.notmuch
- python37Packages.alot
- python37Packages.notmuch
- python38Packages.notmuch
20 packages built:
- agda (agdaPackages.agda)
- agdaPackages.agda-prelude
- agdaPackages.cubical
- agdaPackages.standard-library
- auctex
- cask
- cflow
- cscope
- emacs (emacs26)
- emacs-nox (emacs26-nox)
- framac
- gcl
- gcl_2_6_13_pre
- mozart2
- mu
- pydb
- recutils
- rtags
- supercollider_scel
- why3

@DamienCassou
Copy link
Contributor

@adisbladis This patch seems to break notmuch tests. There are some recent commits in Notmuch repository (especially those from Jonas) that could fix the issues.

@DamienCassou DamienCassou mentioned this pull request Aug 12, 2020
10 tasks
@magnetophon
Copy link
Member

Emacs 27 breaks some modes/packages.
I tried to install emacs 26, but got:

nix-env -iA nixos.emacs26
installing 'emacs-27.1'

@DamienCassou
Copy link
Contributor

Result of nixpkgs-review pr 95169 1

3 packages failed to build:
- agdaPackages.iowa-stdlib
- cedille
- idutils
35 packages built:
- aerc
- afew
- agda (agdaPackages.agda)
- agdaPackages.agda-prelude
- agdaPackages.cubical
- agdaPackages.standard-library
- alot (python38Packages.alot)
- astroid
- auctex
- cask
- cflow
- cscope
- emacs (emacs26)
- emacs-nox (emacs26-nox)
- framac
- gcl
- gcl_2_6_13_pre
- haskellPackages.notmuch
- lieer
- meli
- mozart2
- mu
- muchsync
- neomutt
- notmuch
- notmuch-addrlookup
- pydb
- python27Packages.notmuch
- python37Packages.alot
- python37Packages.notmuch
- python38Packages.notmuch
- recutils
- rtags
- supercollider_scel
- why3

@DamienCassou
Copy link
Contributor

@magnetophon: This is a bug in nixpkgs: emacs26 is indeed Emacs 27. Please report it and CC @adisbladis.

@magnetophon
Copy link
Member

@DamienCassou I thought this is the most appropriate place to report it.
Should I make a separate issue?

@turboMaCk
Copy link
Member

Ah I see I'm not alone who hit this. Issue created.

turboMaCk added a commit to turboMaCk/nixpkgs that referenced this pull request Aug 20, 2020
In NixOS#95169 Emacs was updated to version 27.
however this also changed the explicit emacs26 attribute.

This PR checks back expressions for building Emacs 26 under `emacs26`
attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants