Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc -> Languages & Frameworks -> Rust: Update #95165

Merged
merged 1 commit into from Nov 5, 2020
Merged

Doc -> Languages & Frameworks -> Rust: Update #95165

merged 1 commit into from Nov 5, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented Aug 11, 2020

Add information on declarative overlay usage

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turion
Copy link
Contributor Author

turion commented Aug 11, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 11, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

jshholland
jshholland approved these changes Aug 11, 2020
View reviewed changes
doc/languages-frameworks/rust.section.md Outdated Show resolved Hide resolved
jshholland
jshholland approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@jshholland jshholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@turion
Copy link
Contributor Author

turion commented Aug 14, 2020

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 14, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@turion
Doc -> Languages & Frameworks -> Rust: Update
cd2dab9 
Add information on declarative overlay usage
@wamserma
Copy link
Member

wamserma commented Nov 2, 2020

/marvin needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 5, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@wamserma
Copy link
Member

wamserma commented Nov 5, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox November 5, 2020 12:47
@kevincox kevincox merged commit de57e3b into NixOS:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jshholland jshholland jshholland approved these changes

@symphorien symphorien Awaiting requested review from symphorien

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@turion @wamserma @jshholland @SuperSandro2000 @symphorien @kevincox