Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwto: init at 0.3.0 #95173

Closed
wants to merge 1 commit into from
Closed

jwto: init at 0.3.0 #95173

wants to merge 1 commit into from

Conversation

jtcoolen
Copy link
Member

Motivation for this change

jwto: JSON Web Tokens (JWT) encoding, decoding and verification

Things done
  • [] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtcoolen jtcoolen requested a review from Zimmi48 August 11, 2020 12:45
IvarWithoutBones
IvarWithoutBones reviewed Aug 16, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise LGTM 👍

result of nixpkgs-review pr 95173:

1 package built:
ocamlPackages.jwto

pkgs/development/ocaml-modules/jwto/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/jwto/default.nix Outdated Show resolved Hide resolved
@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2020

@GrahamcOfBorg build ocamlPackages.jwto

vbgl
vbgl reviewed Aug 21, 2020
View reviewed changes
pkgs/development/ocaml-modules/jwto/default.nix
homepage = "https://github.com/sporto/jwto";
description = "JSON Web Tokens (JWT) for OCaml";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ Zimmi48 jtcoolen ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Théo listed as maintainer? (ping @Zimmi48)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theo and I initially decided to use this library for our application coqbot (https://github.com/coq/bot), hence the shared maintenance. We finally implemented JWT by ourselves.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

vbgl pushed a commit that referenced this pull request Aug 21, 2020
@jtcoolen @vbgl
ocamlPackages.jwto: init at 0.3.0 (#95173)
9d57330
@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2020

Merged into master as 9d57330

@vbgl vbgl closed this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones left review comments

@vbgl vbgl vbgl approved these changes

@Zimmi48 Zimmi48 Awaiting requested review from Zimmi48

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtcoolen @vbgl @IvarWithoutBones