Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.b4dm4n.nixpkgs-fmt init at 0.0.1 #95227

Closed
wants to merge 10,000 commits into from

Conversation

zeratax
Copy link
Contributor

@zeratax zeratax commented Aug 12, 2020

Motivation for this change

add vscode extensions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

do you mind rebasing on latest master instead of merging? git pull -r origin master

pkgs/misc/vscode-extensions/nixpkgs-fmt/default.nix Outdated Show resolved Hide resolved
'';

meta = with stdenv.lib; {
description = "Format nix files with nixpkgs-fmt";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add homepage

@zeratax
Copy link
Contributor Author

zeratax commented Nov 26, 2020

I'm currently trying to rebase, but it goes through +10k commits with tons of merge issues, so i've decided to try
git pull -r origin master -Xours
but I'm not sure if that will work. If not I might just create a new PR to supersede this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment