Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: 2.9.11 -> 2.9.12; 2.8.13 -> 2.8.14 #95193

Merged
merged 2 commits into from Aug 11, 2020
Merged

ansible: 2.9.11 -> 2.9.12; 2.8.13 -> 2.8.14 #95193

merged 2 commits into from Aug 11, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

Ansible updates.

Fixes CVE-2020-14332, CVE-2020-1736, CVE-2020-14330 and CVE-2019-14846

CVE Descriptions are not out yet, so I'm not sure where ansible 2.7 stands. It has not had a release so far, but it should have security support until 2.10 gets released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 11, 2020
@mweinelt mweinelt mentioned this pull request Aug 11, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/95193
14 packages built:
ansible ansible-lint ansible_2_8 kargo python27Packages.ansible python27Packages.pytest-ansible python37Packages.ansible python37Packages.ansible-kernel python37Packages.ansible-lint python37Packages.ansible-runner python37Packages.pytest-ansible python38Packages.ansible-kernel python38Packages.ansible-runner python38Packages.pytest-ansible

@jonringer jonringer merged commit 9e6ee27 into NixOS:master Aug 11, 2020
@ofborg ofborg bot requested a review from costrouc August 11, 2020 17:12
@mweinelt mweinelt deleted the ansible branch August 11, 2020 17:15
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @jonringer @TredwellGit