Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python35Packages.pandas: fix build #95217

Closed
wants to merge 3 commits into from
Closed

python35Packages.pandas: fix build #95217

wants to merge 3 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 11, 2020 •
edited

Motivation for this change

It's great being able to switch between interpreter versions effortless in nix, but still need some packages in older interpreter versions.

pin version was determined to be the last stable release which supported python3.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner August 11, 2020 21:28
@jonringer
Copy link
Contributor Author 

[14:31:58] jon@jon-desktop /home/jon/projects/nixpkgs (fix-pandas-py3.5)
$ NIX_BUILD_CORES=16 nix-build -A python35Packages.pandas
/nix/store/5w5178ax15hqjd3gxr1rh7karm1z1zsf-python3.5-pandas-0.25.3

@marsam
Copy link
Contributor

marsam commented Aug 12, 2020

I'm not sure whether we should still maintain Python3.5 since it reaches EOL in a few weeks https://devguide.python.org/#status-of-python-branches (September 13th, 2020)

@jonringer
Copy link
Contributor Author

we've been maintaining python2 8 months past it's EOL, not sure if that's a strong argument. However, the bump from 3.5 to 3.6 is much less than 2.7 to 3.5

@FRidh
Copy link
Member

FRidh commented Aug 12, 2020

For Python 3 we typically keep several versions. My idea is still to drop 3.5 for 20.09 so that we have 3.6 through 3.8 and the 3.9 beta. Python 2 really cannot be compared.

@jonringer
Copy link
Contributor Author

@worldofpeace and I will be meeting friday to go over roadmap. But given the current date, branchoff will be soon, so maybe I'll just remove this.

@jonringer jonringer closed this Aug 12, 2020
@jonringer jonringer deleted the fix-pandas-py3.5 branch August 12, 2020 16:26
@FRidh
Copy link
Member

FRidh commented Aug 12, 2020

@jonringer we spoke earlier about a major package set update. I'll be away on holidays soon and won't find the time to look into that.

@jonringer
Copy link
Contributor Author

@FRidh if you want to initiate one, I can stabilize it. Once I get it to mostly leaf packages are broken, then you can make the determination to merge it then.

@jonringer
Copy link
Contributor Author

should we bump setuptools? not sure how i feel about that package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @marsam @FRidh