mangohud: init at 0.4.1 #95225

zeratax · 2020-08-12T00:09:26Z

Motivation for this change

Things done

I tested this with several OpenGL and Vulkan 32/64 bit games.

Questions

This is currently a little hackish with the combined.nix file, since to use mangohud with 32bit application like a lot of games still are we also need to compile a 32bit version.
but if I just try to build the default.nix file with:

nix-env -f . -iA mangohud
nix-env -f . -iA mangohud --argstr system i686-linux

The second derivation fails with:

error: packages '/nix/store/98anspysbisprqmzr2rwsm9dvgkxzz2z-mangohud-0.4.1/share/vulkan/registry/cgenerator.py' and '/nix/store/hg7vqhxy0kb2kdxm6rrncajb036mjg15-vulkan-headers-1.2.131.1/share/vulkan/registry/cgenerator.py' have the same priority 5; use 'nix-env --set-flag priority NUMBER INSTALLED_PKGNAME' to change the priority of one of the conflicting packages (0 being the highest priority)

The combined.nix now installs both versions next to each other.

~~I am also not using the exact 0.4.1 version, but am a few commits ahead to fix flightlessmango/MangoHud#231 and also flightlessmango/MangoHud@acf2d88~~

~~Or should I include all extra commits with the patches option?~~

Edit: resolved with zeratax#1

kira-bruneau

Thanks for doing this @zeratax!

pkgs/tools/graphics/mangohud/default.nix

kira-bruneau · 2020-08-15T20:30:38Z

There may be a better approach that I don't know about for combining the two builds, but this seems to work. I've also seen other projects use a later rev to get the build working, so I think it should be fine here.

I noticed that you had Tested using sandboxing and Tested execution of all binary files unchecked. Is this correct? It sounds like you may have already completed those.

zeratax · 2020-08-16T19:44:31Z

@MetaDark right yes that was incorrect and I now checked those boxes. I also have a nur package here that seems to build fine: https://travis-ci.com/github/ZerataX/nur-packages
https://github.com/ZerataX/nur-packages/blob/master/default.nix#L19

Atemu

Result of nixpkgs-review pr 95225 1

1 package built:

- mangohud

When I try to run something with it I get a bunch of

MANGOHUD: Failed to open 64bit libnvidia-ml.so.1: libnvidia-ml.so.1: cannot open shared object file: No such file or directory
MANGOHUD: Failed to open 64bit libXNVCtrl.so.0: libXNVCtrl.so.0: cannot open shared object file: No such file or directory

though and it doesn't work :/

pkgs/tools/graphics/mangohud/default.nix

zeratax · 2020-08-17T12:11:50Z

@Atemu so I imagine you are using an nvidia gpu? also would love to know what you tried to run with it? easiest to test is imo vkcube which comes with vulkan-tools. 32bit applications in this version of mangohud require to be run with mangohud.x86

Atemu · 2020-08-17T12:32:01Z

Yes it's an nvidia GPU, sorry should've mentioned that.

I tried Guild Wars 2 but these messages even appear when I try to run bash. Same story with vkcube.

Atemu

Aha! Got it to work. A nix-shell isn't enough, mangohud needs to be in your user env.

The missing library messages still show up weirdly but that's a cosmetic issue we can fix later.

Atemu

zeratax#1

nixos-discourse · 2020-09-04T22:12:18Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/294

pkgs/tools/graphics/mangohud/combined.nix

zeratax · 2020-11-26T13:15:21Z

I was wondering what the current status of this is? Do I just need to rebase this so the commit looks properly (not quite sure how I would go about doing that honestly) or do we wait for #101597 and go for a current release of mangohud?

Atemu · 2020-11-27T04:52:20Z

You should rebase on top of master or unstable and then squash the remaining two commits.

I'd be in favour of merging this as-is and not trying to perfect it by packaging the newest version.
Fixing the bug in our ld.so that prevents the upgrade is way outside this PR's scope I think and will probably require a core maintainer to have a look at. Given how busy they are with more important things than an obscure feature of a core library which 2/70000 packages would need, I wouldn't count on that happening anytime soon.
Same goes for @MetaDark's #92401.

We could try would be to patch the new Mangohud to use the v4 loader again that we did manage to get working here but I think that should happen in a separate PR.

pkgs/tools/graphics/mangohud/combined.nix

pkgs/tools/graphics/mangohud/default.nix

legendofmiracles · 2021-04-23T16:15:47Z

Will you pick this up again @zeratax?

zeratax · 2021-04-23T18:17:34Z

hmm not sure how to squash that merge and my commit properly

Edit: wow I did it!

pkgs/tools/graphics/mangohud/combined.nix

legendofmiracles · 2021-04-25T07:56:47Z

pkgs/tools/graphics/mangohud/default.nix

+
+stdenv.mkDerivation rec {
+  pname = "mangohud${lib.optionalString stdenv.is32bit "_32"}";
+  version = "0.4.1";


newest version is 0.6.1
And rename the commit, if you change the version

Tried it locally, if I manually push the version, the patch doesn't apply.

Versions newer than v4 won't work in Nixpkgs, see #95225 (comment) #101597

legendofmiracles · 2021-04-25T07:57:33Z

Edit: wow I did it!

Nice!
Feel free to add me as a maintainer once you're done

legendofmiracles · 2021-04-25T08:02:08Z

Result of nixpkgs-review pr 95225 run on x86_64-linux 1

1 package failed to build:

mangohud

legendofmiracles · 2021-04-25T08:05:17Z

Well, this is awkward, running the nix-review command again worked flawlessly

legendofmiracles · 2021-04-25T08:06:42Z

Result of nixpkgs-review pr 95225 run on x86_64-linux 1

1 package built:

mangohud

davidak · 2021-04-26T16:37:32Z

Result of nixpkgs-review pr 95225 run on x86_64-linux 1

1 package built:

mangohud

davidak · 2021-04-26T16:59:09Z

Tested using glxgears from mesa-demos.

[nix-shell:~/.cache/nixpkgs-review/pr-95225]$ mangohud glxgears
ERROR: ld.so: object 'libMangoHud.so' from LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS64): ignored.
MANGOHUD: Failed to open 64bit libnvidia-ml.so.1: libnvidia-ml.so.1: cannot open shared object file: No such file or directory
MANGOHUD: Failed to open 64bit libXNVCtrl.so.0: libXNVCtrl.so.0: cannot open shared object file: No such file or directory
MANGOHUD: Failed to open 64bit libX11.so.6: libX11.so.6: cannot open shared object file: No such file or directory
MANGOHUD: Failed to open 64bit libnvidia-ml.so.1: libnvidia-ml.so.1: cannot open shared object file: No such file or directory
MANGOHUD: Failed to open 64bit libXNVCtrl.so.0: libXNVCtrl.so.0: cannot open shared object file: No such file or directory
skipping config: /nix/store/5bx1vwh2v9dxbz5dss3mllrx6q5b7l0n-mesa-demos-8.4.0/bin/MangoHud.conf [ not found ]
skipping config: /home/davidak/.config/MangoHud/glxgears.conf [ not found ]
skipping config: /home/davidak/.config/MangoHud/MangoHud.conf [ not found ]
MANGOHUD: can't find file pci.ids
Version: 4.6 
Running synchronized to the vertical refresh.  The framerate should be
approximately the same as the monitor refresh rate.
329 frames in 5.0 seconds = 65.647 FPS
300 frames in 5.0 seconds = 59.890 FPS
...

Then installed it and tested in Steam by adding mangohud %command% to CS:GO launch options.

[nix-shell:~/.cache/nixpkgs-review/pr-95225]$ nix-env -f nixpkgs/ -i mangohud

That does also work.

Also tested with Half-Life 1 (32-bit).

kira-bruneau · 2021-04-30T23:54:20Z

It looks like the latest version is now 0.6.1, so it would probably be best to update it here.

zeratax · 2021-05-01T00:24:04Z

It looks like the latest version is now 0.6.1, so it would probably be best to update it here.

yeah we decided to do this in a different pr #95225 (comment)

kira-bruneau

yeah we decided to do this in a different pr #95225 (comment)

Oh right thanks, I forgot about that 😅. This looks good to me then, thanks @zeratax!

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 12, 2020

kira-bruneau reviewed Aug 15, 2020

View reviewed changes

pkgs/tools/graphics/mangohud/default.nix Outdated Show resolved Hide resolved

kira-bruneau reviewed Aug 15, 2020

View reviewed changes

pkgs/tools/graphics/mangohud/default.nix Outdated Show resolved Hide resolved

zeratax force-pushed the mangohud branch from 131ac6a to 08d1270 Compare August 16, 2020 20:57

Atemu reviewed Aug 17, 2020

View reviewed changes

pkgs/tools/graphics/mangohud/default.nix Outdated Show resolved Hide resolved

Atemu approved these changes Aug 17, 2020

View reviewed changes

zeratax force-pushed the mangohud branch from 08d1270 to da984e6 Compare August 17, 2020 12:58

Atemu requested changes Aug 19, 2020

View reviewed changes

zeratax force-pushed the mangohud branch from da984e6 to dd25e5e Compare August 21, 2020 02:21

Atemu approved these changes Aug 21, 2020

View reviewed changes

kira-bruneau approved these changes Aug 22, 2020

View reviewed changes

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

samuelgrf reviewed Oct 6, 2020

View reviewed changes

pkgs/tools/graphics/mangohud/combined.nix Outdated Show resolved Hide resolved

ofborg bot removed the 2.status: merge conflict label Oct 10, 2020

samuelgrf approved these changes Oct 10, 2020

View reviewed changes

Atemu reviewed Nov 27, 2020

View reviewed changes

pkgs/tools/graphics/mangohud/combined.nix Outdated Show resolved Hide resolved

zeratax force-pushed the mangohud branch from 9e2cfa7 to 073556a Compare December 12, 2020 21:34

zeratax force-pushed the mangohud branch from 073556a to d31dc2d Compare December 12, 2020 21:37

Atemu approved these changes Dec 13, 2020

View reviewed changes

SuperSandro2000 reviewed Jan 18, 2021

View reviewed changes

pkgs/tools/graphics/mangohud/default.nix Outdated Show resolved Hide resolved

zeratax force-pushed the mangohud branch from d31dc2d to e7b63cf Compare April 23, 2021 17:52

ofborg bot added 2.status: merge conflict and removed 2.status: merge conflict labels Apr 23, 2021

zeratax force-pushed the mangohud branch from d9ea363 to db773e7 Compare April 23, 2021 18:25

zeratax requested a review from SuperSandro2000 April 23, 2021 18:33

SuperSandro2000 reviewed Apr 24, 2021

View reviewed changes

pkgs/tools/graphics/mangohud/combined.nix Show resolved Hide resolved

SuperSandro2000 reviewed Apr 24, 2021

View reviewed changes

pkgs/tools/graphics/mangohud/combined.nix Outdated Show resolved Hide resolved

mangohud: init at 0.4.1

5debc57

zeratax force-pushed the mangohud branch from db773e7 to 5debc57 Compare April 24, 2021 20:46

legendofmiracles reviewed Apr 25, 2021

View reviewed changes

SuperSandro2000 requested a review from Mic92 April 26, 2021 01:00

davidak approved these changes Apr 26, 2021

View reviewed changes

kira-bruneau approved these changes May 1, 2021

View reviewed changes

davidak merged commit 20935f3 into NixOS:master May 1, 2021

zeratax deleted the mangohud branch May 1, 2021 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mangohud: init at 0.4.1 #95225

mangohud: init at 0.4.1 #95225

zeratax commented Aug 12, 2020 •

edited

kira-bruneau left a comment

kira-bruneau commented Aug 15, 2020

zeratax commented Aug 16, 2020

Atemu left a comment •

edited

zeratax commented Aug 17, 2020

Atemu commented Aug 17, 2020

Atemu left a comment

Atemu left a comment

nixos-discourse commented Sep 4, 2020

zeratax commented Nov 26, 2020

Atemu commented Nov 27, 2020

legendofmiracles commented Apr 23, 2021

zeratax commented Apr 23, 2021 •

edited

legendofmiracles Apr 25, 2021 •

edited

Atemu Apr 25, 2021 •

edited

legendofmiracles commented Apr 25, 2021 •

edited

legendofmiracles commented Apr 25, 2021

legendofmiracles commented Apr 25, 2021

legendofmiracles commented Apr 25, 2021

davidak commented Apr 26, 2021

davidak commented Apr 26, 2021 •

edited

kira-bruneau commented Apr 30, 2021 •

edited

zeratax commented May 1, 2021

kira-bruneau left a comment

mangohud: init at 0.4.1 #95225

mangohud: init at 0.4.1 #95225

Conversation

zeratax commented Aug 12, 2020 • edited

Motivation for this change

Things done

Questions

kira-bruneau left a comment

Choose a reason for hiding this comment

kira-bruneau commented Aug 15, 2020

zeratax commented Aug 16, 2020

Atemu left a comment • edited

Choose a reason for hiding this comment

zeratax commented Aug 17, 2020

Atemu commented Aug 17, 2020

Atemu left a comment

Choose a reason for hiding this comment

Atemu left a comment

Choose a reason for hiding this comment

nixos-discourse commented Sep 4, 2020

zeratax commented Nov 26, 2020

Atemu commented Nov 27, 2020

legendofmiracles commented Apr 23, 2021

zeratax commented Apr 23, 2021 • edited

legendofmiracles Apr 25, 2021 • edited

Choose a reason for hiding this comment

Atemu Apr 25, 2021 • edited

Choose a reason for hiding this comment

legendofmiracles commented Apr 25, 2021 • edited

legendofmiracles commented Apr 25, 2021

legendofmiracles commented Apr 25, 2021

legendofmiracles commented Apr 25, 2021

davidak commented Apr 26, 2021

davidak commented Apr 26, 2021 • edited

kira-bruneau commented Apr 30, 2021 • edited

zeratax commented May 1, 2021

kira-bruneau left a comment

Choose a reason for hiding this comment

zeratax commented Aug 12, 2020 •

edited

Atemu left a comment •

edited

zeratax commented Apr 23, 2021 •

edited

legendofmiracles Apr 25, 2021 •

edited

Atemu Apr 25, 2021 •

edited

legendofmiracles commented Apr 25, 2021 •

edited

davidak commented Apr 26, 2021 •

edited

kira-bruneau commented Apr 30, 2021 •

edited