Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulu8: 8.28.0.1 -> 8.48.0.53; zulu: 10.1+11 -> 11.41.23 #95151

Merged
merged 2 commits into from Aug 11, 2020
Merged

zulu8: 8.28.0.1 -> 8.48.0.53; zulu: 10.1+11 -> 11.41.23 #95151

merged 2 commits into from Aug 11, 2020

Conversation

yaroot
Copy link
Contributor

@yaroot yaroot commented Aug 11, 2020 •
edited

Motivation for this change

update zulu jdk to the latest version (same as openjdk in tree)

I plan to rewrite zulu to be more like adoptopenjdk build, add more versions, support arm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and NeQuissimus August 11, 2020 08:47
@NeQuissimus NeQuissimus merged commit 2807aa9 into NixOS:master Aug 11, 2020
@yaroot yaroot deleted the zulu branch August 11, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yaroot @NeQuissimus @Janik-Haag