Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elmPackages.elm-json: init at 0.2.7 #95156

Merged
merged 1 commit into from Aug 16, 2020
Merged

elmPackages.elm-json: init at 0.2.7 #95156

merged 1 commit into from Aug 16, 2020

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Aug 11, 2020 •
edited

elm-json is tool for managing elm.json file. In addition to Elm's built-in elm install command it allows user to uninstall, list or upgrade dependencies.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

turboMaCk
turboMaCk commented Aug 11, 2020
View reviewed changes
pkgs/development/compilers/elm/packages/elm-json.nix
homepage = "https://github.com/zwilias/elm-json";
license = licenses.mit;
maintainers = [ maintainers.turbomack ];
platforms = platforms.linux;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test MacOS at the moment and have a feeling there might be some additional changes needed in order to make this work on mac (Security framework linking etc). So for now we're going to support this only on linux.

@turboMaCk
Copy link
Member Author

@domenkozar This one is ready for review. Thanks in advance.

@domenkozar
Copy link
Member

builder for '/nix/store/1h4p1wcv64ydxws9n8w4dfq5d338kq4i-elm-json-0.2.7.drv' failed with exit code 101

@turboMaCk
Copy link
Member Author

@domenkozar tests are now disabled because they perform networking.

@domenkozar domenkozar merged commit b7f8770 into NixOS:master Aug 16, 2020
@turboMaCk turboMaCk deleted the add-elm-json branch February 2, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turboMaCk @domenkozar