Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vscode extensions/xaver.clang format #95213

Merged
merged 2 commits into from Aug 11, 2020
Merged

Vscode extensions/xaver.clang format #95213

merged 2 commits into from Aug 11, 2020

Conversation

zeratax
Copy link
Contributor

@zeratax zeratax commented Aug 11, 2020

I had to close #83541 since I deleted my fork without thinking about this pull request.

Motivation for this change

More complete vscode-extensions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds fine

@jonringer jonringer merged commit ec01cdc into NixOS:master Aug 11, 2020
@zeratax zeratax deleted the vscode-extensions/xaver.clang-format branch August 11, 2020 19:56
@zeratax zeratax restored the vscode-extensions/xaver.clang-format branch August 21, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeratax @jonringer