Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel_3: use less resources when building Bazel #95214

Merged
merged 1 commit into from Aug 12, 2020
Merged

bazel_3: use less resources when building Bazel #95214

merged 1 commit into from Aug 12, 2020

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 11, 2020 •
edited

Motivation for this change

Limit the resources Bazel is allowed to use during the build to 1/2 the available RAM and 3/4 the available CPU cores. This should help avoid overwhelming the build machine.

The build on Darwin will surely fail due to #93787.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Profpatsch @mboes @avdv

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build bazel_3

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build bazel_3.tests

@kalbasit
bazel_3: use less resources when building Bazel
511c1c7 
Limit the resources Bazel is allowed to use during the build to 1/2 the
available RAM and 3/4 the available CPU cores. This should help avoid
overwhelming the build machine.
@kalbasit kalbasit force-pushed the opensource/nixpkgs/bazel/use-reasonble-resources-during-build branch from b7993ab to 511c1c7 Compare August 11, 2020 20:06
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build bazel_3 bazel_3.tests

@ofborg ofborg bot requested a review from mboes August 11, 2020 21:27
avdv
avdv approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I did not run any tests whatsoever (I am still AFC)

@kalbasit kalbasit merged commit 866eedc into NixOS:master Aug 12, 2020
@kalbasit kalbasit deleted the opensource/nixpkgs/bazel/use-reasonble-resources-during-build branch August 12, 2020 17:47
@Profpatsch
Copy link
Member

Why did this go in the generic section and not in the darwin-specific bits? It’s not broken on Linux, but it will increase the build time for both.

@kalbasit
Copy link
Member Author

It's not darwin specific. My system is a 6 core xeon and 64Gb RAM, building Bazel on my system always crashes it due to a very high load average. The build time should not increase by much, in fact on my system it stayed the same, but it does not crash.

@Profpatsch Profpatsch mentioned this pull request Aug 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdv avdv avdv approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @Profpatsch @avdv