Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cheroot: fix tests #95216

Merged
merged 1 commit into from Aug 12, 2020
Merged

python3Packages.cheroot: fix tests #95216

merged 1 commit into from Aug 12, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 11, 2020 •
edited

Motivation for this change

noticed it was broken in last staging update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

all were previously broken:

https://github.com/NixOS/nixpkgs/pull/95216
5 packages failed to build:
bareos ceph ceph-client libceph samba4Full

14 packages built:
fava flexget mnemosyne python37Packages.cheroot python37Packages.cherrypy python37Packages.pyalgotrade python37Packages.ws4py python37Packages.zerobin python38Packages.cheroot python38Packages.cherrypy python38Packages.pyalgotrade python38Packages.ws4py python38Packages.zerobin tribler

@jonringer jonringer requested a review from FRidh as a code owner August 11, 2020 20:44
@jonringer
Copy link
Contributor Author

fixes builds

@jonringer jonringer merged commit 6410d00 into NixOS:master Aug 12, 2020
@jonringer jonringer deleted the fix-cheroot branch August 12, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer