Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix cni plugin version setting #95174

Closed
wants to merge 1 commit into from
Closed

bug: fix cni plugin version setting #95174

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Aug 11, 2020 •
edited

Motivation for this change

After trying to load these plugins with nomad, I noticed that their version was showing up as version unknown.
Additionally, the version reported by these plugins when pulled from containernetworking/plugins releases shows
a v prefixing the version.

This PR does not address nomad failing to load CNI plugins I'm working on a bug report for that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cpcloud cpcloud mentioned this pull request Aug 11, 2020
Closed
@cpcloud
Copy link
Contributor Author

cpcloud commented Aug 11, 2020

This looks like it could be a bug in the way the buildFlagsArray attribute of buildGoModule is working as well.

saschagrunert
saschagrunert approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zowoq
Copy link
Contributor

zowoq commented Aug 11, 2020 •
edited

This looks like it could be a bug in the way the buildFlagsArray attribute of buildGoModule is working as well.

No, buildFlagsArray seems to be working correctly. The plugins themselves are reporting their version correctly (0.8.6).

zowoq
zowoq requested changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use buildFlagsArray

@cpcloud cpcloud closed this Aug 22, 2020
@cpcloud cpcloud deleted the fix-cni-plugins-version branch August 22, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq requested changes

@saschagrunert saschagrunert saschagrunert approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@vdemeester vdemeester Awaiting requested review from vdemeester

@cstrahan cstrahan Awaiting requested review from cstrahan

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpcloud @zowoq @saschagrunert