Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lf: use buildFlagsArray #95219

Merged
merged 1 commit into from Aug 13, 2020
Merged

lf: use buildFlagsArray #95219

merged 1 commit into from Aug 13, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 11, 2020

Motivation for this change

Noticed this after #95092 was merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from primeos and kalbasit August 11, 2020 23:12
doronbehar
doronbehar approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

(cmd)[nix-shell:~/.cache/nixpkgs-review/pr-95219]$ ./results//lf/bin/lf -version
r15

@zowoq
Copy link
Contributor Author

zowoq commented Aug 13, 2020

@ofborg build lf

primeos
primeos approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, glad to see that works now :) Thanks!

@primeos primeos merged commit 261b6cb into NixOS:master Aug 13, 2020
@zowoq zowoq deleted the lf branch August 13, 2020 08:50
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 13, 2020
@zowoq @dtzWill
lf: use buildFlagsArray (NixOS#95219)
0288101 
(cherry picked from commit 261b6cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@doronbehar doronbehar doronbehar approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @primeos @doronbehar