fpp: bugfix #95218
Merged
fpp: bugfix #95218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
danieldk
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 95218 1
2 packages built:
- fpp
- tmuxPlugins.fpp
Interestingly, the Python subprocess module seems to have an (impure) dependency on /bin/sh
$ wrapit `realpath results/fpp/bin/fpp`
Traceback (most recent call last):
File "/nix/store/vin4yxddc44mgc377g344d2x2p7zaiwp-fpp-0.9.2/share/fpp/src/processInput.py", line 11, in <module>
import parse
File "/nix/store/vin4yxddc44mgc377g344d2x2p7zaiwp-fpp-0.9.2/share/fpp/src/parse.py", line 242, in <module>
PREPEND_PATH = str(getRepoPath().strip()) + '/'
File "/nix/store/vin4yxddc44mgc377g344d2x2p7zaiwp-fpp-0.9.2/share/fpp/src/parse.py", line 212, in getRepoPath
proc = subprocess.Popen(["git rev-parse --show-toplevel"],
File "/nix/store/fjgnz0xfl04hsblsi4ym5y5akfh6mlmy-python3-3.8.5/lib/python3.8/subprocess.py", line 854, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/nix/store/fjgnz0xfl04hsblsi4ym5y5akfh6mlmy-python3-3.8.5/lib/python3.8/subprocess.py", line 1702, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/bin/sh'
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Current derivation causes error:
when invoking fpp, reason is that the bin/fpp looks like this:
While the derivation thinks it looks like this:
So we need to change the replace expression to replace it properly.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)