New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kresd: runtime fixes #95222
kresd: runtime fixes #95222
Conversation
Thanks for ping. I'm not sure I understand – have you ran into some issues? There's tmpfiles spec that should ensure existence of all three. The one for cache was added here as well to
because of ae74a0e. The other two didn't exist before that commit, so they weren't added in the same way. |
To be clear, I see no harm in adding this, so I'm mainly curious. (and perhaps the comments are a bit confusing in combination with these "invisible" tmpfiles rules) |
For some reason the files weren't created on my system. Kept getting CHDIR errors for ( It actually looks like I'm missing Seems like the problem is that the derivation being used has a symlink to the |
Oh, and EDIT: no, that implementation seems safe. I'm looking into making |
#95565 was merged, which should fix the Even on master, the permissions in the @vcunat I think we can use only the per-unit directives here. I sent a patch to upstream at knot-resolver@labs.nic.cz - not sure how to exacty send contributions there. Also opened https://gitlab.nic.cz/knot/knot-resolver/-/issues/596. |
Yes, I think on NixOS the kresd service can abandon using tmpfiles in favor of these, though I can't really see any practical differences. |
4b24b47
to
68366ad
Compare
Using per-unit directives as per NixOS#95222 (comment)
Motivation for this change
Not sure about the directory permissions.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)