New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Pipelines] Use Python 3.8.x for Edge test-suite runs #24952
Conversation
cc @ziransun https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=52438&view=results should be an Edge Dev run with this commit. |
b2b11e1
to
d68f66b
Compare
The Edge run finished but there was an error (I suspect py3-caused) that resulted in it getting no 'revision' tag, which means wpt.fyi won't process it. Unfortunately such errors are deliberately swallowed. I've uploaded a patch that will hopefully log the error, and set off another run - https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=52472&view=results |
29861d5
to
7286c6b
Compare
7286c6b
to
d4fbf0d
Compare
Yep, vcs.py grabs the output of |
https://community-tc.services.mozilla.com/tasks/f0VA2hcISQClpnai1ahO-w/runs/0/logs/live/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2Ff0VA2hcISQClpnai1ahO-w%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log appears to confirm that it shouldn't, but yet we've definitely had successful uploads from Linux+Py3 in the past. Once that run is done I'll pull down both the artifacts for it (to see the run_info) and look at the wpt.fyi logs (to see if and how it passes the processor). |
Moving back to Windows, the latest Edge Dev Py 3.8.5 run fails at the end with:
So there are some bytes somewhere in self.results I guess. |
Success, we have Py3.8.5 + Edge Dev results! https://wpt.fyi/results/?run_id=640430002 https://wpt.fyi/results/?q=is%3Adifferent&run_id=626930002&run_id=640430002 is the diff to the nearest run (2df9cdd has two commits that aren't in the RHS, but should be minor). FYI @ziransun . |
6d0ccd3
to
1c81719
Compare
8c01056
to
a92beed
Compare
a92beed
to
5e802e4
Compare
Doing another Edge run is blocked on #25923 |
5e802e4
to
5a0a6bd
Compare
5a0a6bd
to
e2af840
Compare
I have pushed e2af840 to Will update with a wpt.fyi diff link once the run is done. |
NOT TO BE SUBMITTED
Run installer with repair option
Uninstall existing installation instead of doing folder delete.
afb8026
to
7d2651b
Compare
7d2651b
to
4af6ff5
Compare
This is looking good! I've successfully run two runs, the second of which had to uninstall and reinstall py3.8 and did so fine. I think we're in a good place to turn this into a CL that we could land once we wanted to go to Py3.8 (e.g. by getting rid of most of the debug logging, etc, will do that today). Thanks @mustjab for your work here - very much appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
I don't know much about Powershell but it seems like you've worked with an expert on this :)
See the RFC: web-platform-tests/rfcs#65
This also affects
infrastructure/ tests: Windows 10
, but that job is currently only manually triggered and is basically unused.