Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.construct: 2.9.45 -> 2.10.56 #95189

Merged
merged 2 commits into from Aug 12, 2020
Merged

python.pkgs.construct: 2.9.45 -> 2.10.56 #95189

merged 2 commits into from Aug 12, 2020

Conversation

dotlambda
Copy link
Member

Motivation for this change

make qutebrowser build again

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bjornfor
bjornfor reviewed Aug 11, 2020
View reviewed changes
pkgs/development/python-modules/construct/default.nix
}:

buildPythonPackage rec {
pname = "construct";
version = "2.9.45";
Copy link
Contributor

@bjornfor bjornfor Aug 11, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message disagrees about the old version number.

jonringer
jonringer approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, but commit message is wrong on initial version

@dotlambda dotlambda changed the title python.pkgs.construct: 2.10.54 -> 2.10.56 python.pkgs.construct: 2.9.45 -> 2.10.56 Aug 12, 2020
@ofborg ofborg bot requested a review from bjornfor August 12, 2020 15:51
@dotlambda dotlambda merged commit 72b5ca9 into NixOS:master Aug 12, 2020
@dotlambda dotlambda deleted the construct-2.10.56 branch August 13, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@terlar terlar Awaiting requested review from terlar

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @bjornfor @jonringer