Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pendulum: fix build #95208

Closed
wants to merge 3 commits into from
Closed

python3Packages.pendulum: fix build #95208

wants to merge 3 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 11, 2020 •
edited

Motivation for this change

pendulum switched over to a poetry build

also needed poetry-core to work correctly

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner August 11, 2020 19:02
@mweinelt
Copy link
Member

mweinelt commented Aug 11, 2020 •
edited

Already fixed in d58b4c9 9c50cab 2a1febb.

@mweinelt mweinelt closed this Aug 11, 2020
@jonringer
Copy link
Contributor Author

... literally minutes before i made this

@jonringer jonringer deleted the fix-pendulum branch August 11, 2020 19:07
@jonringer
Copy link
Contributor Author

@mweinelt there was more packaging work done in my PR to enable the packages on other python versions, I opened a new PR with my additional work

@mweinelt
Copy link
Member

@jonringer Sorry, I just skimmed the commit messages, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mweinelt