New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacement: init at 0.4.4 #95210
replacement: init at 0.4.4 #95210
Conversation
Note that CI fails. |
633b005
to
2c65981
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested suggestions.
d420e0a
to
b81c9a1
Compare
@siriobalmelli You did not follow my requests. Please read the link I gave you to nix.dev, and please don't use |
My apologies, I messed that one up. Force-pushed with a specific use of |
b81c9a1
to
ae3e97d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes nixpkgs-review
build and --help
test.
ae3e97d
to
55b5687
Compare
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch> Co-Authored-By: Doron Behar <doron.behar@gmail.com>
55b5687
to
32c27dd
Compare
It is a bit questionable whether we should include this package, see https://discourse.nixos.org/t/we-need-more-defined-guidelines-for-package-inclusion/3592. Is anybody other than you using this @siriobalmelli? Alternatively you could also use NUR to distribute the package. |
I see what you mean. This particular package has been around since 2018 and is in use downstream of me. You will see in the project history that a nix derivation was first added in day 2 of development. Part of the motivation in trying to get it accepted into nixpkgs is so those downstreams don't have to always point to https://github.com/siriobalmelli-foss/nixpkgs or use a custom import like: replacement = import (builtins.fetchGit {
url = "https://siriobalmelli@github.com/siriobalmelli/replacement.git";
ref = "master";
}) {}; Re: maintenance I don't foresee a problem - Nix is in heavy use in our shop, I am a regular contributor to nixpkgs and I'm signing off as the maintainer of this package: I can always be pinged if it becomes a problem later. In getting adoption for Nix with other engineers, it would be of enormous aid having them be able to install Nix as per standard and then just run Based on the above, please consider merging this: it makes it that much more productive to contribute to nixpkgs in my own time if I can leverage the same nixpkgs to improve efficiency on other projects :) |
Sounds good then! |
Signed-off-by: Sirio Balmelli sirio@b-ad.ch
Motivation for this change
Add new python package for use in a Nix CI/CD
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)