Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpack: init at 1.1.0 #95846

Merged
merged 1 commit into from Aug 27, 2020
Merged

kpack: init at 1.1.0 #95846

merged 1 commit into from Aug 27, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Aug 20, 2020 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Aug 20, 2020

@GrahamcOfBorg build kpack

@siraben
Copy link
Member Author

siraben commented Aug 21, 2020

Builds on both NixOS and macOS.

@siraben siraben changed the title kpack: init at 1.0.1 kpack: init at 1.1.0 Aug 21, 2020
ryantm
ryantm requested changes Aug 22, 2020
View reviewed changes
pkgs/development/tools/misc/kpack/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/kpack/default.nix

src = fetchFromGitHub {
owner = "KnightOS";
repo = "kpack";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = "kpack";
repo = pname;

@ryantm
Copy link
Member

ryantm commented Aug 22, 2020

Result of nixpkgs-review pr 95846 1

1 package built:
- kpack

siraben
siraben commented Aug 22, 2020
View reviewed changes
Copy link
Member Author

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit suggestions

@siraben
Copy link
Member Author

siraben commented Aug 22, 2020

We may want the repo name to differ from the package name, see #95890 (comment)

@siraben siraben mentioned this pull request Aug 22, 2020
Closed
@siraben siraben requested a review from ryantm August 27, 2020 02:55
@ryantm ryantm merged commit 6004c46 into NixOS:master Aug 27, 2020
@siraben siraben deleted the kpack branch August 27, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @ryantm