relibc: build from source #95848
Merged
relibc: build from source #95848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
reviewed
Aug 21, 2020
| buildPackages.stdenv.cc.libc | ||
| "$out" | ||
| ]; | ||
| bootstrapCrossRust = stdenvNoCC.mkDerivation { |
There was a problem hiding this comment.
I would normally be pedantic and say this should be stdenvNoCC.mkDerivationbuildPackages.stdenvNoCC.mkDerivation (and then you could probably just use autoPatchelfHook too), but I think this is about to be replaced in the other PRs so I am not oo concerned :).
Feel free to open another PR if you think this might last more than a few days, though.
There was a problem hiding this comment.
I would normally be pedantic and say this should be stdenvNoCC.mkDerivation
I assume that's a typo, because it's stdenvNoCC.mkDerivation already?
There was a problem hiding this comment.
Sorry! I meant to write buildPackages.stdenvNoCC.mkDerivation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
For #93661. Building things from source is generally good. I could eventually bootstrap even further from source, but for now, this PR should be a good step forward.
This PR also makes it easier for Nix users to contribute to relibc source code.
P.S. @Ericson2314 I'm close to getting a relibc-based toolchain working for Linux, after which I'll make a PR to add linux to relibc's
meta.platforms:-)Things done
I tested this by building a full Redox VM from it.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)