eddy: init at 2020/04/16 #95857
Closed
eddy: init at 2020/04/16 #95857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
requested changes
Aug 21, 2020
| }; | ||
|
|
||
| propagatedBuildInputs = [ | ||
| qt5.full |
There was a problem hiding this comment.
Should be in buildInputs.
| python37Packages.pyqt5 | ||
| ]; | ||
|
|
||
| doCheck = false; |
|
|
||
| doCheck = false; | ||
|
|
||
| HOME = "/tmp"; |
| HOME = "/tmp"; | ||
|
|
||
| preFixup = '' | ||
| wrapProgram $out/bin/eddy --prefix JAVA_HOME ":" ${jre}; |
There was a problem hiding this comment.
Since Python programs are already wrapped, this causes double wrapping. You should be able to use something like this:
Suggested change
| wrapProgram $out/bin/eddy --prefix JAVA_HOME ":" ${jre}; | |
| makeWrapperArgs+=(--prefix JAVA_HOME ":" ${jre}) |
|
|
||
| python37Packages.buildPythonApplication rec { | ||
| pname = "eddy"; | ||
| version = "2020-04-16"; |
There was a problem hiding this comment.
They have a stable release: https://github.com/obdasystems/eddy/releases/tag/v1.2.0
|
Closing cause the author did not address the reviewer feedback in the last months. Feel free to reopen the discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add new package in nixpkgs
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)