New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Python 3: Decode HEX value back to single quote #25141
Conversation
@Hexcles: I'm not sure this CL gives a good solution. Just try to find out why the escaping character in policy value ('self') has been converted Hex value in python 3 case. Anything obvious to you? |
6e01419
to
a1e1b29
Compare
Where is Looks like we are getting the URL-encoded version of the string. |
It should come from this line
That's what I suspected as well. I couldn't see any direct calls of .py file in these test scripts. Could it be something at wpt core part? |
@ziransun yeah I'm looking at wptserve. Meanwhile, could you provide some concrete examples (comparison of strings in Py2 and 3, as well as the test that triggers it)? |
Hmm, I also see
in Python 2. In other words, this doesn't seem to happen in Python 3 only. Reading the source code, I think this is the expected behaviour: wpt/tools/wptserve/wptserve/handlers.py Lines 143 to 150 in 0f986ae
sets |
#25275 landed, so let's close this PR. |
No description provided.