Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud-client: 2.6.5 -> 3.0.0 #95850

Merged
merged 1 commit into from Sep 25, 2020
Merged

nextcloud-client: 2.6.5 -> 3.0.0 #95850

merged 1 commit into from Sep 25, 2020

Conversation

claudiiii
Copy link
Contributor

@claudiiii claudiiii commented Aug 20, 2020 •
edited

Motivation for this change

New version of nextcloud-client was released recently (v3.0.0).
There is currently a bug nextcloud/desktop#2279 that requires several restarts of nextlocud-client to load all synced folders. I think it's best to wait until this is resolved before merging.
I have not tested any file manager integration!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from caugner and Ma27 August 20, 2020 22:02
@Ma27
Copy link
Member

Ma27 commented Aug 21, 2020

Subscribed to the original issue. Let's wait for an upstream fix then.

@afontaine
Copy link
Contributor

It looks like a fix has been merged in as of nextcloud/desktop#2436, so I imagine once a 3.0.2 release is out (current is 3.0.1), it should be fixed 👍

@afontaine
Copy link
Contributor

Looks like 3.0.2 just dropped https://github.com/nextcloud/desktop/releases/tag/v3.0.2

@Ma27
Copy link
Member

Ma27 commented Sep 24, 2020

@afontaine ah good to know. Can you please update the package here?

@afontaine afontaine mentioned this pull request Sep 24, 2020
Merged
10 tasks
@afontaine
Copy link
Contributor

@Ma27 I opened a new PR #98685 containing this + the 3.0.2 update

@Ma27 Ma27 closed this in e958a89 Sep 25, 2020
@Ma27 Ma27 merged commit 5703813 into NixOS:master Sep 25, 2020
@claudiiii claudiiii deleted the update-nextcloud-client branch February 2, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner Awaiting requested review from caugner

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@claudiiii @Ma27 @afontaine