Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rescuetime: 2.14.5.2 -> 2.16.3.1 #95860

Closed
wants to merge 1 commit into from
Closed

rescuetime: 2.14.5.2 -> 2.16.3.1 #95860

wants to merge 1 commit into from

Conversation

steshaw
Copy link
Member

@steshaw steshaw commented Aug 20, 2020 •
edited

Motivation for this change

I am trying to upgrade NixOS but I can't because rescuetime is broken. See #87226.

$ sudo nixos-rebuild switch --upgrade

The shas were broken for 2.14.5.2 because the urls where pointing directly at the current version of rescuetime. e.g.

https://www.rescuetime.com/installers/rescuetime_current_amd64.deb

So, I've upgraded to the latest version, fixed the urls, and changed the sha256s.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/). NOTE: only able to test amd64 platform.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor

rescuetime was already updated in #93770. But this seems to be a newer version, perhaps you could rebase this PR on master?

@steshaw
Copy link
Member Author

steshaw commented Aug 20, 2020

@danieldk I sure can. I did intentionally want to 20.03 as it's broken and I can't upgrade. I'll rebase it on master, then how can we ensure that it is cherry-picked into nixos-20.03?

@steshaw steshaw mentioned this pull request Aug 21, 2020
Merged
10 tasks
@steshaw steshaw closed this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steshaw @danieldk