Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nss on macOS #94587

Merged
merged 3 commits into from Aug 6, 2020
Merged

Fix nss on macOS #94587

merged 3 commits into from Aug 6, 2020

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Aug 3, 2020
@ofborg ofborg bot requested a review from codyopel August 3, 2020 03:49
@vcunat
Copy link
Member

vcunat commented Aug 3, 2020

Oh, I thought we fixed darwin in #93534

@matthewbauer
Copy link
Member Author

Oh, I thought we fixed darwin in #93534

That made it build - but the install name is relative to the executable without d0468f8.

@vcunat
Copy link
Member

vcunat commented Aug 3, 2020

Hmm, tough for people without a macOS to fix, if the builds themselves don't test such things.

@vcunat vcunat merged commit ce174c7 into NixOS:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @vcunat @marsam