Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mastodon-bot: 1.0.2 -> 1.0.4 #94556

Closed
wants to merge 1 commit into from
Closed

mastodon-bot: 1.0.2 -> 1.0.4 #94556

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Aug 2, 2020

Motivation for this change

Mainly to get the bugfix from yogthos/mastodon-bot#57

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dasj19
dasj19 approved these changes Aug 2, 2020
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds without problems with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94556"

@raboof
Copy link
Member Author

raboof commented Aug 10, 2020

This change since made it in as part of #91142

@raboof raboof closed this Aug 10, 2020
raboof added a commit to raboof/mastodon-bot-nix that referenced this pull request Dec 5, 2020
@raboof
Use nixpkgs branch: update to mastodon-bot 1.0.4
9d13ad0 
To get early access to NixOS/nixpkgs#94556
and thus yogthos/mastodon-bot#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @dasj19