Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: altair-transform: init at 0.2.0 #94591

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: altair-transform: init at 0.2.0 #94591

wants to merge 1 commit into from

Conversation

CMCDragonkai
Copy link
Member

Motivation for this change

Adding altair-transform to do server-side transformations of the Vega lite transform later.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member Author

Don't know why I need jinja2 in the checkInputs, but it complains when I don't put it in.

@CMCDragonkai
Copy link
Member Author

I'm getting this error:

nix-repl> :b pkgs.python3Packages.altair-transform
error: recommonmark-0.6.0 not supported for interpreter python3.8

@jonringer
Copy link
Contributor

nix-repl> :b pkgs.python3Packages.altair-transform
error: recommonmark-0.6.0 not supported for interpreter python3.8

Unfortunately it's true. I'll try to fix

@jonringer
Copy link
Contributor

try rebasing off latest master

@ryantm ryantm marked this pull request as draft October 23, 2020 02:59
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CMCDragonkai @jonringer @ryantm