[WPT] Add tests for sandbox directive for shared/service workers #24845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 2, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2333908
branch
from
81142b6
to
d5c9268
Compare
These tests confirm sandbox directives are no-op for workers, because sandbox directive is not yet specified for workers. (This CL doesn't add tests for dedicated workers, because dedicated workers inherit parent Document's CSP, the parent Documents should be sandboxed and thus it's hard to test whether dedicated workers from sandboxed Documents are sandboxed) Bug: 1112143, w3c/webappsec-csp#279 Change-Id: Iff34da98de61214584681ae6f12ffcbf1dee1880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333908 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#796736}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2333908
branch
from
d5c9268
to
9389e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests confirm sandbox directives are no-op for workers,
because sandbox directive is not yet specified for workers.
(This CL doesn't add tests for dedicated workers, because
dedicated workers inherit parent Document's CSP,
the parent Documents should be sandboxed and thus it's hard
to test whether dedicated workers from sandboxed Documents
are sandboxed)
Bug: 1112143, w3c/webappsec-csp#279
Change-Id: Iff34da98de61214584681ae6f12ffcbf1dee1880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333908
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796736}