python3Packages.brother: init at 0.1.14 #94568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsix
reviewed
Aug 3, 2020
There was a problem hiding this comment.
nix-review gives me that:
[8 built (2 failed), 105 copied (197.3 MiB), 43.9 MiB DL]
error: build of '/nix/store/wark1gyjszmbycf8xw9k1sn9cm5s2cbz-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/94568
2 packages failed to build:
python27Packages.pytest-tornasync python37Packages.brother
5 packages built:
python37Packages.pytest-tornasync python37Packages.pytest-trio python38Packages.brother python38Packages.pytest-tornasync python38Packages.pytest-trioI did not look into it, but it should be looked into or some packages should probably be disabled for some python versions (if this is the problem).
|
I set pytest-toransync to >=3.5. The python3.7 version of brother is failing in asynctest, which has had its test disabled for 3.8, which is apparently also necessary for 3.7, see 25b91c2. |
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
10 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
|
Disabled the asynctest tests on python 3.7 in #94655. Thinks are looking good now afaict. |
jonringer
reviewed
Aug 4, 2020
jonringer
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 94568 1
1 package failed to build:
- python27Packages.pytest-tornasync
6 packages built:
- python37Packages.brother
- python37Packages.pytest-tornasync
- python37Packages.pytest-trio
- python38Packages.brother
- python38Packages.pytest-tornasync
- python38Packages.pytest-trio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable the brother integration in home-assistant.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)