nixos/dokuwiki: fix https redirect #94551
Conversation
There was a problem hiding this comment.
What do you do for dns? For our internal sites I use dns challenge with let's encrypt to provision ssl certificates and it's dead simple. I would highly recommend this over the alternative (though I still approve this PR 👍).
Also I'm a huge fan of your avatar 😄
Even if the webserver had https disabled, the user would still get redirected to an https url when attemting to login.
|
@GrahamcOfBorg test dokuwiki |
|
Alright, thanks for the quick review :) |
There was a problem hiding this comment.
I basically agree with what @aanderse said. Just for the record, I was thinking about dropping the current SSL configuration altogether as it's imposing a given configuration on the user rather than leaving it up to him/her: #83769 (comment)
@dadada I think we should also document this service in the 20.09 release notes as the service changed from single-site to multi-site and this may break existing configuration.
You mean the documentation or dropping SSL forcing? |
|
Either or. I'm simply hoping that the action items will have someone to follow-up on them 😄 |
Ok, I did both :) #94609. |
Even if the webserver had https disabled, the user would still get redirected to an https url when attemting to login.
This fixes #94550
Motivation for this change
Fixes broken login behavior when https is disabled.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)