Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump technote-space/get-diff-action from v2.0.2 to v2.0.3 #94593

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 3, 2020

Bumps technote-space/get-diff-action from v2.0.2 to v2.0.3.

Changelog

Sourced from technote-space/get-diff-action's changelog.

{ "inputs": { "OUTPUT_BUILD_INFO_FILENAME": "build.json", "TEST_TAG_PREFIX": "test/", "CLEAN_TEST_TAG": "true" } }

Commits
  • b1acdd3 Merge pull request #95 from technote-space/release/next-v2.0.2
  • 23643fe chore: update npm dependencies
  • 7429a8c chore: update npm dependencies
  • 2945894 chore: update npm dependencies
  • 523722a chore: update npm dependencies
  • 398e909 chore: update npm dependencies
  • 651dd5b feat: update package version
  • fc1a6f5 chore: update npm dependencies
  • d8fc217 Merge pull request #94 from technote-space/release/next-v2.0.1
  • ecb5e12 Merge branch 'master' into release/next-v2.0.1
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from Mic92 and zowoq as code owners August 3, 2020 07:18
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 3, 2020
@zowoq zowoq force-pushed the dependabot/github_actions/technote-space/get-diff-action-v2.0.3 branch from 5abbe14 to e6b686d Compare August 3, 2020 08:09
@@ -10,6 +10,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a bit quicker to do this first rather than letting the get-diff-action do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to see about rewriting git history to remove checked in tarballs, binaries, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has anybody committed this in the past?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked a while back out of curiosity, IIRC there was at least one large tarball and a few other things that probably shouldn't have been checked in.

I think I saved the results somewhere, I'll see if i can find them or I'll recheck the repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the original but quick scan (excluding nix & json files) shows:

77ff01cf186e  1.0MiB pkgs/stdenv/linux/tools/bash
ff689f7e31a9  1.7MiB pkgs/stdenv/nix-linux-static/bash-static/bash-2.05b-static.tar.gz
f57b203eee2c  2.6MiB pkgs/stdenv/nix-linux-static/gcc-static/gcc-3.3.4-static.tar.gz
c7207aec8964  3.5MiB pkgs/os-specific/linux/blcr/fixes.patch
dc1d9b1f1784   39MiB pkgs/stdenv/linux/bootstrap-tools.cpio.bz2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewriting history sound quite bad though. Is it even possible do this in non-destructive way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think it's possible.

@Mic92 Mic92 merged commit c4ba980 into master Aug 3, 2020
@Mic92 Mic92 deleted the dependabot/github_actions/technote-space/get-diff-action-v2.0.3 branch August 3, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants