Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.1.10 -> 6.1.12 #94594

Closed
wants to merge 1 commit into from
Closed

virtualbox: 6.1.10 -> 6.1.12 #94594

wants to merge 1 commit into from

Conversation

nthorne
Copy link
Contributor

@nthorne nthorne commented Aug 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Magicloud
Copy link
Contributor

Hi, not sure if there is something else I need to do. I cannot build this on my minimal NixOS. VBOX_WITH_CLOUD_NET led to building CloudGateway.cpp which does not exist.

@bryanasdev000
Copy link
Member

bryanasdev000 commented Dec 28, 2020 •
edited

I believe that this PR can now be closed, we already have 6.1.16 and a PR #107421 to include it on 20.09.

@blitz
Copy link
Contributor

blitz commented Feb 11, 2021

I'm just taking the liberty of closing this stale MR to avoid confusing people. :)

@blitz blitz closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nthorne @Magicloud @bryanasdev000 @blitz @ryantm