Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shipyard: init at 0.1.17 #94561

Merged
merged 1 commit into from Jan 6, 2021
Merged

shipyard: init at 0.1.17 #94561

merged 1 commit into from Jan 6, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Aug 2, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit August 2, 2020 16:49
doronbehar
doronbehar requested changes Aug 3, 2020
View reviewed changes
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
pkgs/tools/virtualization/shipyard/default.nix Show resolved Hide resolved
@cpcloud
Copy link
Contributor Author

cpcloud commented Aug 8, 2020

Looks like a new release happened since I opened this PR, going to give this one a new title and rebase+squash.

@cpcloud cpcloud changed the title shipyard: init at 0.0.37 shipyard: init at 0.1.0 Aug 8, 2020
@cpcloud cpcloud requested a review from doronbehar August 8, 2020 12:02
doronbehar
doronbehar approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and --help test.

SuperSandro2000
SuperSandro2000 requested changes Nov 29, 2020
View reviewed changes
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Please disable the failing test:

panic: mkdir /homeless-shelter: permission denied [recovered]
    panic: mkdir /homeless-shelter: permission denied

goroutine 15 [running]:
testing.tRunner.func1.1(0x1b2f0c0, 0xc000133890)
    testing/testing.go:1072 +0x30d
testing.tRunner.func1(0xc000a6a780)
    testing/testing.go:1075 +0x41a
panic(0x1b2f0c0, 0xc000133890)
    runtime/panic.go:969 +0x1b9
github.com/shipyard-run/shipyard/pkg/utils.ShipyardTemp(0x52af11, 0xc00096f380)
    github.com/shipyard-run/shipyard/pkg/utils/utils.go:129 +0xe6
github.com/shipyard-run/shipyard/pkg/clients.TestContainerCreatesDirectoryForVolume(0xc000a6a780)
    github.com/shipyard-run/shipyard/pkg/clients/docker_tasks_container_create_test.go:293 +0x4c
testing.tRunner(0xc000a6a780, 0x1e14418)
    testing/testing.go:1123 +0xef
created by testing.(*T).Run
    testing/testing.go:1168 +0x2b3
FAIL    github.com/shipyard-run/shipyard/pkg/clients    0.047s
FAIL

@SuperSandro2000
Copy link
Member

@cpcloud Please fix the merge conflict

@cpcloud cpcloud force-pushed the shipyard branch 2 times, most recently from 8b0328e to 7ce7125 Compare January 3, 2021 16:16
@cpcloud cpcloud changed the title shipyard: init at 0.1.0 shipyard: init at 0.1.17 Jan 3, 2021
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 3, 2021

@SuperSandro2000 Fixed!

@doronbehar
Copy link
Contributor

@cpcloud please squash the commits.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 6, 2021

@doronbehar On it.

@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 94561 run on x86_64-linux 1

1 package built:
  • shipyard

@doronbehar doronbehar merged commit 41d68e4 into NixOS:master Jan 6, 2021
@cpcloud cpcloud deleted the shipyard branch May 11, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpcloud @SuperSandro2000 @doronbehar