Add break-inside: avoid to the content in the second column
#24848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://drafts.csswg.org/css-break/#possible-breaks, UAs may consider any elements with `overflow: hidden` monolithic. Firefox can break between `Column2` and `Column2 line2` in the reference. Add `break-inside: avoid` to prevent that to match the test behavior.
mstensho
approved these changes
Aug 3, 2020
|
Indeed, Firefox doesn't honor orphans and widows. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://drafts.csswg.org/css-break/#possible-breaks, UAs may
consider any elements with
overflow: hiddenmonolithic.Firefox can break between
Column2andColumn2 line2in thereference. Add
break-inside: avoidto prevent that to match the testbehavior.