Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted red edges #666

Closed
phkahler opened this issue Aug 2, 2020 · 3 comments · Fixed by #667
Closed

Unwanted red edges #666

phkahler opened this issue Aug 2, 2020 · 3 comments · Fixed by #667
Labels
bug

Comments

@phkahler
Copy link
Member

phkahler commented Aug 2, 2020

System information

SolveSpace version: 3.0~fd2dfe87

Operating system: Fedora 31

Expected behavior

Model should display with no red edges.

Actual behavior

Model has red edges, or even stray red segments.

Additional information

When the 8 circles cut into the center hole or sometimes the outer ring, these red edges appear. Analyze indicates no naked edges. I'm opening this issue to document it before submitting a PR that was not intended to fix it but does.

Red_Edges
@whitequark whitequark added the bug label Aug 2, 2020
@phkahler phkahler mentioned this issue Aug 2, 2020
Merged
@phkahler phkahler linked a pull request Aug 2, 2020 that will close this issue
Remove the Random() function and use a fixed table of arbitrary vecto… #667
Merged
@phkahler
Copy link
Member Author

phkahler commented Aug 3, 2020

Looking through the text window I see several "can't find a ray that doesn't hit on edge!" messages. They go away with the patch.

phkahler added a commit to phkahler/solvespace that referenced this issue Aug 3, 2020
@phkahler
Remove the Random() function and use a fixed table of arbitrary vecto…
06189b4 
…rs in raycast.cpp

This also fixes issue solvespace#666.
@ruevs
Copy link
Member

ruevs commented Aug 3, 2020

Please attach the model.

@phkahler
Copy link
Member Author

phkahler commented Aug 3, 2020

A_wheel.zip

Remember, random numbers are a platform dependent implementation so you may not see this problem on Windows. OTOH it is very easy to get multiple failures on my setup.

phkahler added a commit that referenced this issue Aug 3, 2020
@phkahler
Remove the Random() function and use a fixed table of arbitrary vecto…
3c2f82b 
…rs in raycast.cpp

This also fixes issue #666.
@ruevs ruevs mentioned this issue Oct 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the Random() function and use a fixed table of arbitrary vecto… phkahler/solvespace
3 participants
@whitequark @phkahler @ruevs