Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gammastep: init at 2.0.1 #94565

Merged
merged 2 commits into from Aug 6, 2020
Merged

gammastep: init at 2.0.1 #94565

merged 2 commits into from Aug 6, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 2, 2020 •
edited

Motivation for this change

Should work but I need to properly test it (on my test system it crashed but that's probably because the hardware doesn't support gamma adjustments and it looks similar to https://gitlab.com/chinstrap/gammastep/-/issues/3).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and lukateras August 2, 2020 18:37
@primeos primeos marked this pull request as ready for review August 3, 2020 16:04
@primeos
Copy link
Member Author

primeos commented Aug 3, 2020

I did test this successfully on Sway now. Gammastep is now recommended in the Sway wiki as Redshift replacement (instead of the previous fork (redshift-wlr)):

@globin @yegortimoshenko mind if I reuse the mkRedshift for this? It seemed to make sense for now as the expression is quite complex and gammastep is a fork of redshift.

And we can probably replace redshift-wlr with gammastep in the future but I wouldn't do it right away.

@doronbehar
Copy link
Contributor

@GrahamcOfBorg build redshift

@primeos
redshift,redshift-wlr: Fix a file path in postInstall
3f5258b
@primeos
gammastep: init at 2.0.1
79415b0 
Note: Since Gammastep is a fork of Redshift the mkRedshift will be
reused as long as they don't diverge too far.
Also: Gammastep should eventually replace redshift-wlr.
@primeos primeos merged commit 4fe5107 into NixOS:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar requested changes

@globin globin Awaiting requested review from globin

@lukateras lukateras Awaiting requested review from lukateras

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @doronbehar