Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/editorconfig.yml: separate fetch and check steps #94575

Merged
merged 1 commit into from Aug 3, 2020
Merged

.github/workflows/editorconfig.yml: separate fetch and check steps #94575

merged 1 commit into from Aug 3, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 2, 2020

Separate steps should be easier to read.

Also rename the tool to match what we have packaged.

/nix/store/bnlc49ibgdy904mlpv67h3x6jnf17xz7-editorconfig-checker-2.1.0/bin/editorconfig-checker

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs rebasing.

mv ./bin/ec-$OS-$ARCH ./bin/editorconfig-checker
- name: Checking EditorConfig
run: |
./bin/editorconfig-checker -disable-indentation \
Copy link
Member

@mweinelt mweinelt Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line break does not feel necessary, even with the line below you are below 80 characters. And IMO it does not improve readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for when multiple files are edited so that they are all after the break rather than being cut off.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, works for me.

@mweinelt mweinelt merged commit f284867 into NixOS:master Aug 3, 2020
@zowoq zowoq deleted the ecc-actions branch August 3, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants