Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: openjdk: 8u242b08 -> 8u265b01 #94573

Closed
wants to merge 1 commit into from
Closed

wip: openjdk: 8u242b08 -> 8u265b01 #94573

wants to merge 1 commit into from

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Aug 2, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixos  ~/dev/src/nix/nixpkgs/pkgs/development/compilers/openjdk   update-java8  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 483, done.
remote: Counting objects: 100% (483/483), done.
remote: Total 774 (delta 483), reused 483 (delta 483), pack-reused 291
Receiving objects: 100% (774/774), 204.71 KiB | 1.15 MiB/s, done.
Resolving deltas: 100% (575/575), completed with 192 local objects.
From https://github.com/NixOS/nixpkgs
   ad7c4e495a4..f9b0bc3f297  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-22f9798bcbed6fb692e54bca5748fa8b0311d78f-dirty/nixpkgs f9b0bc3f2972a09c0abda75c1d2f6148858ab7c2
Preparing worktree (detached HEAD f9b0bc3f297)
Updating files: 100% (22285/22285), done.
HEAD is now at f9b0bc3f297 rss2email: 3.12 -> 3.12.1
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-22f9798bcbed6fb692e54bca5748fa8b0311d78f-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edwtjo and NeQuissimus August 2, 2020 21:28
@asbachb asbachb changed the title openjdk: 8u242b08 -> 8u265b01 wip: openjdk: 8u242b08 -> 8u265b01 Aug 2, 2020
@asbachb
Copy link
Contributor Author

asbachb commented Aug 4, 2020

aarch64 checksums seems to be wrong.

@NeQuissimus NeQuissimus mentioned this pull request Aug 6, 2020
Merged
10 tasks
@asbachb asbachb closed this Aug 6, 2020
@asbachb asbachb deleted the update-java8 branch January 25, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbachb @NeQuissimus