New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vend: Use nix-community fork of vend. #94574
Conversation
Note that pkgs.govendor is currently taken by a package which is orphaned by upstream. It's mildly confusing to have vend point to nix-community/govendor, but I felt govendor was a better name for the nix tool since it's easy to understand what's it's for, compared to vend which won't really make sense to anyone who doesn't package go.
IMHO it is more than just mildly confusing. I am not in favour for the name collision with another Go vendoring tool even if it is abandoned. |
Is there maybe a third name not used by anything? How about |
What's the issue with https://github.com/nomad-software/vend, are they not accepting patches? Unless the project is a complete rewrite, I would keep the same name. It's not great, live with it :-D If we have to fork it, I would also make sure that the repo is recorded as a fork of upstream for clarity's sake, and add an explanation to the README to explain why we need a long-term fork. |
nomad-software/vend@dc54ecb Upstream seems to have implemented their own version of replacements. |
The main motivation is to prevent checksum breaks. Upstream does not care about this too much and automatic updates by r-ryantm might introduce silent checksum changes. The tool itself is not overly complex that's why I think maintaining it our self is the better way to not break things in |
There are a couple of different ways to prevent the bot sending PRs. |
In order of importance for me is:
I would re-fork upstream into nix-community/vend, rename the repo to nix-community/nixpkgs-vend and update the README with a quick explanation about the fork. And then update nixpkgs and rename the package as well. |
I've checked a few packages and the upstream replacements seems to work. Upstream has also removed Assuming that the upstream version is suitable for us to use I think we could just pin the version and disable the update bot. Adding a warning should be sufficient to prevent accidental upgrades in the event someone does try to bump it manually. Update: Upstream However it breaks |
So the only patch left would be the mod-tidy one? @c00w what is your opinion about having the fork? |
Note that pkgs.govendor is currently taken by a package which is
orphaned by upstream. It's mildly confusing to have vend point to
nix-community/govendor, but I felt govendor was a better name for the
nix tool since it's easy to understand what's it's for, compared to vend
which won't really make sense to anyone who doesn't package go.
I manually checked that the same hashes were generated by the new tool.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)