Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osm2pgsql: 1.2.1 -> 1.2.2 #91740

Merged
merged 1 commit into from Jun 29, 2020
Merged

osm2pgsql: 1.2.1 -> 1.2.2 #91740

merged 1 commit into from Jun 29, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Jun 28, 2020

Motivation for this change

upstream release, with buxfixed version 2.15.6 of libosmium (vendored in the osm2pgsql repo, so bumping osm2pgsql separately from PR #91725 is needed.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

1 package built:
- osm2pgsql

@ofborg ofborg bot requested a review from jglukasik June 28, 2020 21:26
danieldk
danieldk approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91740 1

1 package built:
- osm2pgsql

Binary works.

@danieldk danieldk merged commit 7419b8d into NixOS:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@jglukasik jglukasik Awaiting requested review from jglukasik

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @danieldk