Fix html/coep/require-corp.https.html flakiness #24377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case asserts that frame.contentDocument is not null, by assuming that the message arrives at the parent frame before the child frame navigates out, which actually is not guaranteed. Remove the assertion.
wpt-pr-bot
requested review from
arturjanc,
domenic,
foolip,
hemeryar,
jdm,
jgraham,
jugglinmike,
mikewest,
ParisMeuleman,
valenting,
zcorpan and
zqzhang
|
Hmm, I wonder if that should be guaranteed. Does |
|
The child frame
The broadcast message can arrive after 3. |
We can test the nullness of contentDocument in a synchronous manner because contentDocument is not null only if the frame is in the same agent. But the problem here is the asynchronous nature of postMessage. |
annevk
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case asserts that frame.contentDocument is not null, by
assuming that the message arrives at the parent frame before the
child frame navigates out, which actually is not guaranteed. Remove
the assertion.