Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clash: 0.20.0 -> 1.0.0 #91705

Merged
merged 1 commit into from Jun 28, 2020
Merged

clash: 0.20.0 -> 1.0.0 #91705

merged 1 commit into from Jun 28, 2020

Conversation

LEXUGE
Copy link
Contributor

@LEXUGE LEXUGE commented Jun 28, 2020

Simply bump the version as upstream released the new version a few hours ago.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LEXUGE
clash: 0.20.0 -> 1.0.0
40d120d 
Simply bump the version as upstream released the new version a few hours ago.
@LEXUGE LEXUGE requested a review from Br1ght0ne June 28, 2020 06:14
@ofborg ofborg bot requested review from contrun and kalbasit June 28, 2020 06:22
@contrun
Copy link
Contributor

contrun commented Jun 28, 2020

Building passed. The executable works.

@Br1ght0ne Br1ght0ne merged commit 408fd63 into NixOS:master Jun 28, 2020
@Br1ght0ne
Copy link
Member

Thanks @LEXUGE!

@LEXUGE LEXUGE deleted the patch-2 branch June 28, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contrun contrun contrun approved these changes

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LEXUGE @contrun @Br1ght0ne