Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gSpeech: 0.9.2 -> 0.10.1 #91718

Merged
merged 1 commit into from Aug 21, 2020
Merged

gSpeech: 0.9.2 -> 0.10.1 #91718

merged 1 commit into from Aug 21, 2020

Conversation

mothsART
Copy link
Contributor

Motivation for this change

gSpeech 0.10 bring 2 big features :

  • control the reading speed
  • reading text bigger than 30000 characters
Things done

For reading text bigger than 30000 characters, gSpeech need sox dependance.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member

davidak commented Jul 18, 2020

@mothsART does it actually work for you?

I built it with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 91718", but it does not work.

Example from readme gspeech-cli -i "mon chat s'appelle maurice" gives no output and gspeech starts no GUI (Pantheon desktop). Same with previous version.

@mothsART
Copy link
Contributor Author

@davidak : gspeech works for me well with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 91718" :

  1. gspeech launched on gnome-shell and unity
  2. gspeech-cli -i "mon chat s'appelle maurice" product a gspeech.wav as expected and the content is consistent.

gspeech launch on systray : appindicator firstly and gtk StatusIcon on fallback.
appindicator seems to be the better case to future and my usage.
There are still cases where the use of the statusicon does not work well.
I will try to launch gspeech in an VM with Pantheon.

In all cases, the concern comes from the application code and not from the packaging.

thanks for feedback.

@Lassulus Lassulus merged commit 6979b39 into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mothsART @davidak @Lassulus