Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libosmium: 2.15.5 -> 2.15.6 #91725

Merged
merged 2 commits into from Jun 28, 2020
Merged

libosmium: 2.15.5 -> 2.15.6 #91725

merged 2 commits into from Jun 28, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Jun 28, 2020

Motivation for this change

Upstream bugfix release.

Releases on GitHub:

Upstream code changes:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g
Copy link
Member Author

das-g commented Jun 28, 2020

Result of nixpkgs-review pr 91725 1

5 packages built:
- libosmium
- osmium-tool
- python27Packages.pyosmium
- python37Packages.pyosmium
- python38Packages.pyosmium

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91725 1

5 packages built:
- libosmium
- osmium-tool
- python27Packages.pyosmium
- python37Packages.pyosmium
- python38Packages.pyosmium

Also checked that the tool and Python modules run/load.

@danieldk danieldk merged commit 70ca51c into NixOS:master Jun 28, 2020
@das-g das-g mentioned this pull request Jun 28, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants