New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nss: 3.52.1 -> 3.54 #91746
nss: 3.52.1 -> 3.54 #91746
Conversation
Unfortunately this is currently based on staging commit where firefox fails to build with
EDIT: cross-ref: #85189 (comment) (solved) |
For now I just tried building these atop current staging-next (x86_64 NixOS). Firefox 77 and 78 (#92043) both started up and showed some pages OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issue with this. EDIT: looked at upstream release notes, too.
ccc22cc
to
e152e55
Compare
There another instance of patching .mk files, in Also: we might not want merge this as is, because it will break at least firefox-est-68, see #92043 |
The errors seem to be about some changes in C++ class inheritance:
|
If they planned full compatibility, I wouldn't see a reason for this line in there:
Perhaps we'll (eventually) be forced to use a different NSS versions for ESR and non-ESR :-/ |
I also tested 3.53.1, the current LTS release, but 68esr (which is still supported for at least one release, I think?) doesn't compile with that, either. |
I asked upstream and they said the "intended" version for ESR 68 is 3.44.4. They also opened this issue https://bugzilla.mozilla.org/show_bug.cgi?id=1651505 I don't feel like I'm in the position to make a decision on if we should have two versions of NSS, drop ESR 68 or whatever else to do, so I'll probably have to leave this as is, for now. |
@GrahamcOfBorg build nss |
Cross gets broken by this PR 😞 I tried usual x86_64 -> armv7l. First issue with wrong python2 is fixed by switching to |
As for |
Yeah, turns out I didn't remember how nixpkgs uses "host"… It still fails like this, though:
|
@vcunat cross compilation should work now. I've asked upstream what's up with them trying to run a target (or build in nixpkgs terms) binary during build. |
@GrahamcOfBorg build nss |
@GrahamcOfBorg build nss |
The darwin builders seem stuck again. Let's merge this into staging, if it breaks the darwin build, it can still be fixed during the staging cycle. |
Well, darwin is broken: https://hydra.nixos.org/build/124134212 |
Motivation for this change
This has been out for a bit and the FireFox release due tomorrow requires 3.53+
As noted in #89438, there are some issues with this update. They were most likely introduced in nss-dev/nss@eee8f82.
Looking at how we're building this, I noticed that we're using the legacy build system.
The new one depends on gyp, which depends on python2. That's not great, but at least it works.
The patches are commented out, because with them it failscc @andir @vcunat
TODO