Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint: fix 1.9 #91721

Merged
merged 1 commit into from Jun 28, 2020
Merged

pylint: fix 1.9 #91721

merged 1 commit into from Jun 28, 2020

Conversation

rski
Copy link
Contributor

@rski rski commented Jun 28, 2020

It depends on pyenchant, which is disabled on python2. This results
in:

nix-env -iA unstable.python27Packages.pylint
replacing old 'python2.7-pylint-1.9.5'
installing 'python2.7-pylint-1.9.5'
error: pyenchant-3.1.1 not supported for interpreter python2.7

Remove it, à la
eb0d5fc
and now it builds again.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rski
pylint: fix 1.9
dfcd82a 
It depends on pyenchant, which is disabled on python2. This results
in:
```
nix-env -iA unstable.python27Packages.pylint
replacing old 'python2.7-pylint-1.9.5'
installing 'python2.7-pylint-1.9.5'
error: pyenchant-3.1.1 not supported for interpreter python2.7
```

Remove it, à la
NixOS@eb0d5fc
and now it builds again.
@rski rski mentioned this pull request Jun 28, 2020
Merged
10 tasks
@Ma27 Ma27 merged commit 165ed2a into NixOS:master Jun 28, 2020
@rski rski deleted the pylint-19 branch September 19, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rski @Ma27